somakd / fad

Factor Analysis for Data in R
3 stars 1 forks source link

Define STRICT_R_HEADERS, include float.h #4

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Dear Somak, dear fad team,

Your CRAN package fad uses Rcpp, and is affected if we add the definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at https://github.com/RcppCore/Rcpp/issues/1158 and the links therein for more context on this.

Here, I prefixed three #include with STRICT_R_HEADERS. One additional change that is needed is the #include of (or cfloat if you prefer C style, that is equivalent) to define DBL_EPSILON, DBL_MIN, ...

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by https://github.com/RcppCore/Rcpp/issues/1158 to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.