search

somakeit / door-controller2

A new door controller for a new space, where all the previous hardware is broken and we can't replace it.
1 stars 0 forks source link

Blacklist detected clones. #20

Closed brackendawson closed 2 years ago

brackendawson commented 8 years ago

Right now we just don't let the clone or original in when it's behind count, we did this in case we got false positives, which we have had none and should not get any. So we should now blacklist cloned tags.

We can very effectively blacklist them by erasing the secret in the database. The tag will be rendered un-usable, but we will still have the MIFARE keys to re-use the physical hardware.

brackendawson commented 8 years ago

Consider the path where we successfully read both sectors but fail to validate the newer one due to uncorrected transmission errors (extremely unlikely). You can work around this by bailing out of validate() if a tag had a validation error and it is behind count.

brackendawson commented 2 years ago

Not going to fix this as the code is no longer used.