IATI parsing - Githubissues

somaliaims / Somali-AIMSUI

GNU Affero General Public License v3.0

1 stars 3 forks source link

IATI parsing #298

Open matmaxgeds opened 5 years ago

matmaxgeds commented 5 years ago

For this IATI activity: http://d-portal.org/q.xml?aid=XM-OCHA-CBPF-SOM-18%2F3485%2FSA1%2FEd%2FINGO%2F8577

We are not picking up:

the 'receiver' organisation from the transactions
the percentage value of the location
We are not picking up both sectors (use the narrative for the "99" one, ignore if is 99 and no narrative)

Education

matmaxgeds commented 5 years ago

but we should do this systematically - i.e. if you can point me to the parser, I can look at what fields you are picking up so far and we can go from there

matmaxgeds commented 5 years ago

Not picking up all organisations
Not picking up dates
Need to pick sector codes (+vocab code) and then look up the code name on the codelist (via the codelists API) - and noting that if no vocab is given, then it is DAC 5 codes.....

raashidahmad commented 4 years ago

Please use the link given below to track the progress and discuss issues: https://docs.google.com/document/d/1Jj0R6VrcSiXrgn7DIA9eT09VHtZ4Xv8uKmmnvEZJEkQ/edit?usp=sharing

Link to parser code if it is helpful https://github.com/somaliaims/Somali-AIMS/blob/master/AIMS.APIs/AIMS.IATILib/Parsers/ParserIATIVersion21.cs

matmaxgeds commented 4 years ago

Moved to after launch, but we will need to work on this again

raashidahmad commented 4 years ago

@matmaxgeds Closing this as this issue relates to the previous UI for data entry.

matmaxgeds commented 4 years ago

@raashidahmad unfortunately I suspect that the problem still exists. Re-opening until I can investigate again.

matmaxgeds commented 4 years ago

[ ] Parse and present the grant/loan status
[ ] get default currencies when not included in the activity (have to lookup the file the activity came from, may be easier in new datastore as it may do this for you)
[ ] the percentage value of the location
[ ] For sectors (use the narrative for the "99" or "98" ones, ignore sector information if is it 98 or 99 vocabulary and has no narrative)
[ ] Get activities where recipient_country=SO at the transaction level, not just the activity level....see other github issue for the new datastore which should have a better query which should do this (not really a parsing thing)

Also, the parsing code includes sections on recipient_county and recipient_region that we don't need? How come they are there? See lines 486-514.

matmaxgeds commented 4 years ago

This needs to wait for the resolution to the new datastore issue therefore moving to Phase 2