search

somasis / gnome-colors-old

Automatically exported from code.google.com/p/gnome-colors
0 stars 0 forks source link

Chromium wrong frame color (+ fix) #113

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Start chromium-browser or google-chrome
2. Right click on the empty space next to the tabs -> select "use system 
title bar and borders"

What is the expected output? What do you see instead?
The frame should have the color of the title bar, instead it has the 
selected_bg color.

Please provide any additional information below.

It's an easy fix though, all you have to do is add frame_color and 
inactive_frame_color values to the gtk_color_scheme (#2E2E2E seems the 
correct value):

gtk_color_scheme = 
"fg_color:#101010\nbg_color:#D8D8D8\nbase_color:#fff\ntext_color:#1A1A1A\ns
elected_bg_color:#F7A145\nselected_fg_color:#fff\ntooltip_bg_color:#F5F5B5\
ntooltip_fg_color:#000\nframe_color:#2E2E2E\ninactive_frame_color:#2E2E2E"

See the attachment for a before/after comparison

Original issue reported on code.google.com by tibault....@gmail.com on 23 Aug 2009 at 11:00

Attachments:

GoogleCodeExporter commented 9 years ago 
I forgot to mention you also need to use the GTK+ theme:
<wrench> -> "Options" -> "Personal Stuff" -> "Set to GTK+ theme"

I should also mention that in the current ubuntu build of Chromium 4.0.203.0 
(svn20090825r24230) this behavior appears to be broken, Chromium no longer 
picks the 
theme color, but reverts to the default blue.

This will probably be fixed soon, but for now you can still test this behavior 
with 
Google Chrome.

Original comment by tibault....@gmail.com on 26 Aug 2009 at 9:57

GoogleCodeExporter commented 9 years ago 
Heh, you can already forget about the second part, the current build 
(4.0.204.0~svn20090826r24440) is fine again.

So to summarize, here's the full how-to-reproduce:

What steps will reproduce the problem?
1. Start chromium-browser or google-chrome
2. Right click on the empty space next to the tabs -> select "use system 
title bar and borders"
3. <wrench> -> "Options" -> "Personal Stuff" -> "Set to GTK+ theme"

(https://launchpad.net/~chromium-daily/+archive/ppa)

Original comment by tibault....@gmail.com on 26 Aug 2009 at 8:13

GoogleCodeExporter commented 9 years ago 
Thanks for the report and the fix, sorry for the slow reply. Right now I just 
started
college again, so things are a bit hectic.. Perhaps over the weekend I can test
things and commit your fix.

Original comment by perfectska04 on 26 Aug 2009 at 8:20

GoogleCodeExporter commented 9 years ago 
Now fixed in SVN. Should be there in the next release!

Original comment by perfectska04 on 25 Sep 2009 at 3:46

GoogleCodeExporter commented 9 years ago

Original comment by perfectska04 on 25 Sep 2009 at 3:47

GoogleCodeExporter commented 9 years ago 
Great!
I see you noticed Google changed the frame code a bit, so the #2e value was no 
longer 
correct.
It's hard to pick the right value as the code still changes so often, but in my 
current build (4.0.129.0ubuntu27064) #31 seems like a better choice than #33 
(nitpicking, I know :P )

Attachment: from top to bottom: #33, #32, #31, #30

Original comment by tibault....@gmail.com on 25 Sep 2009 at 6:11

Attachments:

GoogleCodeExporter commented 9 years ago 
I tested it using the chromium PPA, so I'm not sure if it's the very latest. I 
did do
some matching, and "#333333" was the closest match with that build. For Dust,
"#3B3630" worked well. I guess it's subjective, as it takes the color and uses 
weird
gradients to draw it - instead of just using the flat color.

It is a bit weird, though... In reality, Chromium *should* use "#3C3C3C", as 
that is
the first shade color at the bottom of the Metacity.

Original comment by perfectska04 on 25 Sep 2009 at 6:25