Correct calculation of a string tensor length

somaticio / tensorflow.rb

tensorflow for ruby

BSD 3-Clause "New" or "Revised" License

827 stars 66 forks source link

Correct calculation of a string tensor length #26

Closed sebastiandeutsch closed 8 years ago

sebastiandeutsch commented 8 years ago

It's a temporary solution to fix #17. But somehow it's a hack:

It's actually assuming that there are strings in the tensor.
It currently can't deal with multi dimensional string arrays.
Encoding issues of strings are not covered.

chrhansen commented 8 years ago

@sebastiandeutsch looks good to me.

Perhaps it would be a good idea to add 1-2 extra specs with some odd cases for the string tensor so we know the fix is solid.

➜  tensorflow.rb-sebastian git:(bugfix/correct-calculation-of-tensor-buffer-length) rspec
.............................................

Finished in 0.71852 seconds (files took 0.24137 seconds to load)
45 examples, 0 failures

arafatkatze commented 8 years ago

@sebastiandeutsch This is very nice. Thanks.