Fix default op-naming - Githubissues

chrhansen commented 8 years ago

I began implementing tf.zeros (a special kind of constant-op with all 0s – taking only shape as required argument) and found that our constant()-method doesn't work with scalars and doesn't take shape as an argument. Writing specs for that, I then discovered that our default_names- method uses a character, :, that makes it unretrievable from the TensorFlow graph.

: is not allowed in names on the actual (not the wrapper) TensorFlow graph
make constant() compliant (https://www.tensorflow.org/versions/r0.10/api_docs/python/constant_op.html#constant), e.g. work on scalars and take shape as argument
... then build zeros()

chrhansen commented 8 years ago

At this point this PR only fixes the op-naming issues and adds a few extra specs, but I'm still working on implementing tf.zeros and fixing tf.constant. Merging wont do harm, should it happen.

arafatkatze commented 8 years ago

@chrhansen I will make the constant work with the specifications soon. Thanks a lot for this.

chrhansen commented 8 years ago

@Arafatk well, wait off with that – as I wrote above I'm already working on that.

arafatkatze commented 8 years ago

@chrhansen Just one thing, I have done something similar in image branch for this. Thanks

chrhansen commented 8 years ago

@Arafatk ?

arafatkatze commented 8 years ago

@chrhansen In image recognition tutorial, I had made a few changes so that I could read scalars but it was not the best way to make scalars work.

somaticio / tensorflow.rb

Fix default op-naming #59