Required gems to run should be defined as runtime dependency

somaticio / tensorflow.rb

tensorflow for ruby

BSD 3-Clause "New" or "Revised" License

827 stars 66 forks source link

Required gems to run should be defined as runtime dependency #73

Closed hokuma closed 7 years ago

hokuma commented 7 years ago

ruby-protocol-buffers and narray are used in library implementations.

ex.

https://github.com/somaticio/tensorflow.rb/blob/57969b0f5ed537ffbefd4bf9a10488621e7acf9b/lib/tensorflow/graph.rb#L167
https://github.com/somaticio/tensorflow.rb/blob/57969b0f5ed537ffbefd4bf9a10488621e7acf9b/lib/tensorflow/core/framework/tensor_slice.pb.rb#L4

Required gems to run should be defined as runtime dependency.

See: http://guides.rubygems.org/patterns/#declaring-dependencies

chrhansen commented 7 years ago

@hokuma that sounds plausible! I'm wondering if we should also remove our Gemfile.lock based in Yehuda's advice: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

arafatkatze commented 7 years ago

@hokuma Thanks a lot for the contribution. @chrhansen Yes, removing the Gemfile.lock seems right after reading the post and the few other answers on Stack overflow.