someaddons / weathersettings

Weather settings mod
0 stars 0 forks source link

[Feature request]: A clear weather setting added to the weatherEntries #6

Open pwaksman973 opened 5 days ago

pwaksman973 commented 5 days ago

Describe the bug you're experiencing

A clear weather setting added to the weatherEntries, or a sample of a clear object if one already exists.

Why? Having rain, and thunder really make 0 difference in preventing rain, since it will result in the sum of the weights

People usually want to reduce rain. Like for me it rains like every 2 or 3 days, even worst when it start to rain just after you slept.

Having one more entry like "clear", then it would make sense to have the weight as a control over the rain frequency something like

{
  "skipWeatherOnSleep": {
    "desc:": "Whether to skip weather after sleeping: default:false",
    "skipWeatherOnSleep": true
  },
  "clearWeatherCommand": {
    "desc:": "Command for clean weather",
    "clearWeatherCommand": "weather clear"
  },
  "weatherEntries": {
    "desc:": "Weather entries, duration in seconds. Weight is the chance to be chosen out of the sum of all weights",
    "weatherEntries": [
      {
        "world": "minecraft:overworld",
        "rain": {
          "command": "weather rain",
          "weight": 50,
          "duration": 200,
          "clearDuration": 3600
        },
        "thunder": {
          "command": "weather thunder",
          "weight": 5,
          "duration": 80,
          "clearDuration": 1500
        }
        "clear": {
          "command": "no rain",
          "weight": 800,
          "duration": 10,
          "clearDuration": 0
        }
      }
    ]
  }
}

Reproducability

just a suggestion

Mod up to date

Minecraft version

1.21.1

Modloader version

Neoforge

Logs

no logs

someaddons commented 2 days ago

actually you already have control over the frequency, it depends on the length of the "clearDuration" entry. The higher you set it the longer the weather is clear before the next one is chosen