somehowchris / rocket-validation

A guard to validate data received by rocket via validator
16 stars 4 forks source link

Update to support rocket =0.5.0-rc.4 #28

Closed kije closed 10 months ago

kije commented 11 months ago

Relates to https://github.com/somehowchris/rocket-validation/issues/27

codecov[bot] commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (42c7e55) 17.60% compared to head (1173eb2) 13.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================== - Coverage 17.60% 13.24% -4.36% ========================================== Files 4 4 Lines 1761 2310 +549 ========================================== - Hits 310 306 -4 - Misses 1451 2004 +553 ``` | [Files](https://app.codecov.io/gh/somehowchris/rocket-validation/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christof+Weickhardt) | Coverage Δ | | |---|---|---| | [tests/test\_query.rs](https://app.codecov.io/gh/somehowchris/rocket-validation/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christof+Weickhardt#diff-dGVzdHMvdGVzdF9xdWVyeS5ycw==) | `100.00% <100.00%> (ø)` | | | [src/lib.rs](https://app.codecov.io/gh/somehowchris/rocket-validation/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christof+Weickhardt#diff-c3JjL2xpYi5ycw==) | `8.83% <25.00%> (-3.19%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

turboMaCk commented 10 months ago

Thanks @kije for picking it up and @somehowchris for the merge. I wonder if there is any plan to release updated version of create. For now I will use current master commit as a dependency but I feel people will start updating and will require this.

ghost-in-the-zsh commented 10 months ago

The crates.io package entry needs to be updated. In the meantime, for those who are still getting compilation errors after the Rocket 0.5.0 release, you can use this in your Cargo.toml file to target a specific branch:

rocket-validation = { git = "https://github.com/somehowchris/rocket-validation.git", branch = "main" }
somehowchris commented 10 months ago

Hi, sry, had a bit of a rough patch, will be published by the end of the week, currently digging through all the Issues and PRs in my projects.