someshkar / covid19india-cluster

:microscope: Covid19 India Cluster Graph
https://cluster.covid19india.org
MIT License
989 stars 654 forks source link

feat (Patient selection UI): Zoom to selected patient #34

Closed SahajR closed 4 years ago

SahajR commented 4 years ago

This is a basis for the search feature #21.

Currently, a useEffect hook reacts to a selected user in the graph. I have currently rewritten the store state to remove the redundant selected field.

For the search by Id to work, we can find the coords of the patient (after finding it by id) through the vis.js API. Let me know if I should go ahead with this next step. I'll also add a search input in the side panel for the purpose.

Waiting for your response after the review.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/someshkar/covid19india-network/kbfh3loyg ✅ Preview: https://covid19india-network-git-fork-sahajr-feat-zoom.someshkar.now.sh

someshkar commented 4 years ago

Can you make a search and zoom to patient UI? Like a searchbar where you can find a patient by Id/City/Travel History and zoom to the patient on the map?

This would be a lot more useful.

Also, please resolve the merge conflicts with the latest commit to the master branch.

SahajR commented 4 years ago

Alright.

SahajR commented 4 years ago

@someshkar Added search by patient id. Review if this workflow works. If so, I will add search capabilities with other criteria and finish this feature to close #21

someshkar commented 4 years ago

@SahajR this works really well! Merging.