City view crashes, "item with id ... already exists"

answerquest commented 4 years ago

Steps to reproduce:

Go on https://cluster.covid19india.org/
Click the City icon in right sidebar

Observation:

Page is replaced by a single sentence : "An unexpected error has occurred."
Console log shows 2 errors:

Error: Cannot add item: item with id 7701c8e38a5d97b93a8ff527ff556ef31940bd5d already exists
    at t.value (e32c019e.a37cbf266f11b1830d7a.js:1)
    at t.value (e32c019e.a37cbf266f11b1830d7a.js:1)
    at t.value (index.js:1)
    at t.value (index.js:1)
    at wi (framework.1aca562006664c5eb2f5.js:1)
    at Va (framework.1aca562006664c5eb2f5.js:1)
    at ko (framework.1aca562006664c5eb2f5.js:1)
    at xu (framework.1aca562006664c5eb2f5.js:1)
    at wu (framework.1aca562006664c5eb2f5.js:1)
    at du (framework.1aca562006664c5eb2f5.js:1)

main-38f8a3fdb67c1679a368.js:1 Error: Cannot add item: item with id 7701c8e38a5d97b93a8ff527ff556ef31940bd5d already exists
    at t.value (e32c019e.a37cbf266f11b1830d7a.js:1)
    at t.value (e32c019e.a37cbf266f11b1830d7a.js:1)
    at t.value (index.js:1)
    at t.value (index.js:1)
    at wi (framework.1aca562006664c5eb2f5.js:1)
    at Va (framework.1aca562006664c5eb2f5.js:1)
    at ko (framework.1aca562006664c5eb2f5.js:1)
    at xu (framework.1aca562006664c5eb2f5.js:1)
    at wu (framework.1aca562006664c5eb2f5.js:1)
    at du (framework.1aca562006664c5eb2f5.js:1)

My surface guess is that id 7701c8e38a5d97b93a8ff527ff556ef31940bd5d is repeating in the data somewhere. If the data is coming from outside the scope of this repo, then this alert needs to be shared with the folks in charge of it.

Fix Proposal

In case this is a problem that can recur later on as well and it's beyond the scope of this repo to influence a fix, then we have to do on-the-fly adjustment to make the site still work.
Should run a data-cleaning function upon data fetch before passing it into the viz
Delete off or re-id dupes to make do and proceed; but also dump the dupe catch in the console log.
If possible, send out an api call to report this error. Matomo is a good OS solution - normally a hits tracker, but can be repurposed to capture specific messages.

vrajeshkanna commented 4 years ago

Detailed error

Uncaught Error: Cannot add item: item with id 7ec65df9a6f2816d565962afff630ba8dd1fba261 already exists
    at t.value (vis-network.esm.min.js:25)
    at t.value (vis-network.esm.min.js:25)
    at Graph.patchNodes (index.js:178)
    at Graph.shouldComponentUpdate (index.js:86)
    at checkShouldComponentUpdate (react-dom.development.js:12716)
    at updateClassInstance (react-dom.development.js:13233)
    at updateClassComponent (react-dom.development.js:17131)
    at beginWork (react-dom.development.js:18653)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237)
    at invokeGuardedCallback (react-dom.development.js:292)
    at beginWork$1 (react-dom.development.js:23234)
    at performUnitOfWork (react-dom.development.js:22185)
    at workLoopSync (react-dom.development.js:22161)
    at performSyncWorkOnRoot (react-dom.development.js:21787)
    at react-dom.development.js:11111
    at unstable_runWithPriority (scheduler.development.js:653)
    at runWithPriority$1 (react-dom.development.js:11061)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11106)
    at flushSyncCallbackQueue (react-dom.development.js:11094)
    at discreteUpdates$1 (react-dom.development.js:21924)
    at discreteUpdates (react-dom.development.js:1071)
    at dispatchDiscreteEvent (react-dom.development.js:4168)

Looks like this hash belongs to Kerala state

Screenshot from 2020-03-25 12-29-44

sibeshkar commented 4 years ago

Still trying to figure this one out.

sibeshkar commented 4 years ago

fixed in https://github.com/someshkar/covid19india-network/pull/54

someshkar / covid19india-cluster