search

someshkar / covid19india-cluster

:microscope: Covid19 India Cluster Graph
https://cluster.covid19india.org
MIT License
989 stars 654 forks source link

Adding a button to toggle the visibility of the day picker #63

Closed srikrishnamoorthis closed 4 years ago

srikrishnamoorthis commented 4 years ago

Hi Somesh,

I have added a button to toggle the Visibility of the day picker for the following issue https://github.com/someshkar/covid19india-network/issues/57.

Let me know if any changes are required.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/someshkar/covid19india-network/3gknclu5d ✅ Preview: https://covid19india-network-git-fork-srikriss-master.someshkar.now.sh

sibeshkar commented 4 years ago

Hey thanks! Can you change the styles a bit so it looks like this. bg white, border-radius 5px and width 200px.

image

srikrishnamoorthis commented 4 years ago

Day picker has width of 280 px. Setting the button width to 200px looks like this

image

(please ignore border colour)

sibeshkar commented 4 years ago

Why is it abruptly moving to the left when expanded? Should stay in place, then the width won't matter.

srikrishnamoorthis commented 4 years ago

Since container is a flex box, by default items gets aligned by flex-start property. it can be changed.

If difference in the widths of day picker and button is fine & acceptable , then it will look like this

image
sibeshkar commented 4 years ago

Looks good. Do push