someshkar / covid19india-cluster

:microscope: Covid19 India Cluster Graph
https://cluster.covid19india.org
MIT License
989 stars 654 forks source link

Search bar should search through city, state, travel dest too #81

Open anandmuthu007 opened 4 years ago

anandmuthu007 commented 4 years ago

Try to add search bar for search state and city in cluster.it will become easy to find. State wise patients details.

iam-gopi commented 4 years ago

There is a search bar in the Cluster page which search based on the Patient name alone. Is that ok make it support other search criteria as well like State, patient name etc?

sibeshkar commented 4 years ago

@SahajR can you try dealing with this? As cases are ballooning, it's becoming more difficult to zoom into the city/state you want to check. Thanks :)

SahajR commented 4 years ago

I can do this. I need to know all the possible inputs and expected behavior for each.

For example, what should happen if I search City Name ? If in city mode, I can focus on the city node, but if not, what should be focused on?

SahajR commented 4 years ago

@sibeshkar Hey just checking back since I didn't hear from you. We can discuss all the UI requirements for search before going ahead.

sibeshkar commented 4 years ago

Sorry just missed this among avalanche of notifs. I think best will be if there's a key of each node which is used to fuzzy search through the nodes and zoom in if there's a match. In search bar, this would look like : "Type city, state or patient number to searh...".

SahajR commented 4 years ago

Ok so we need to also notify the user that they need to be in a certain filter for a particular search to work. because the clustering graph changes only after a filter is set initially.

sibeshkar commented 4 years ago

"Type city, state or patient number to search...". This text will change based on which filter you apply?

SahajR commented 4 years ago

Yes, that's fine, but what happens if the user searches Delhi if the graph is in patient mode?

sibeshkar commented 4 years ago

Nothing happens (we can red-highlight the input box to indicate no matches), which indicates there are no nodes which match

SahajR commented 4 years ago

ok. Will start with this tomorrow morning.

sibeshkar commented 4 years ago

Thank you!