somesocks / lua-lockbox

A collection of cryptographic primitives written in pure Lua
MIT License
357 stars 74 forks source link

Modulesnameproposal #4

Closed tst2005 closed 8 years ago

tst2005 commented 8 years ago

Hello,

I really happy and enjoyed by your crypto modules! Unfortunately, I think your module naming approach is not very good. You chose to name them like "MD5" or "SHA1" it force to use only one implementation. I currently play with different implementations...

I made a try to name everything prefixed by lockbox and every module name in lowercase.

local md5 = require "lockbox.digest.md5"

The full list of modules names was added into the README.

This approach :

I make this pull request before you provide a luarocks support. All tests passed with Lua5.2.

I also work to provide a full Lua version compat to support Lua 5.1, 5.2, 5.3, LuaJIT 2.0 and 2.1. I will make another pull request for that.

Regards,

somesocks commented 8 years ago

Good call! Merged.