search

somesocks / lua-lockbox

A collection of cryptographic primitives written in pure Lua
MIT License
362 stars 75 forks source link

Rename AES args using 'unused hint' in naming #41

Closed blueyetisoftware-jason closed 1 year ago

blueyetisoftware-jason commented 1 year ago

@blueyetisoftware-jason good idea, but I'd like to use standard terms as much as possible so that it's easy to compare the code to standards papers.

In this case, the AES reference paper from NIST (https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.197.pdf) uses the term 'key' for the input key, and 'key schedule' for the expanded key used in the actual block cipher rounds.

So, if you change 'seed' with 'key' and 'key' with 'keySchedule', it's a 👍 from me, and I'll merge it ASAP

Done. Thanks