search

somesocks / lua-lockbox

A collection of cryptographic primitives written in pure Lua
MIT License
357 stars 74 forks source link

Added workaround for bit operaitions in incomplete environments #43

Closed AmsTaFFix closed 7 months ago

AmsTaFFix commented 1 year ago

Added workaround to add necessary functions. It will be helpful in environments, where not all necessary bit functions exists

AmsTaFFix commented 1 year ago

@somesocks

greatwolf commented 1 year ago

Which version of Lua/LuaJIT is this workaround for?

AmsTaFFix commented 1 year ago

Which version of Lua/LuaJIT is this workaround for?

World of Warcraft LUA implementation

AmsTaFFix commented 8 months ago

@greatwolf does this PR suitable to merge, or I just should delete it?

greatwolf commented 8 months ago

It's up to @somesocks, I'm kind of neutral on it. I'm still wondering why WoW is using such an old version of Lua that doesn't have native bitwise operations in it.

somesocks commented 7 months ago

I think my perspective is compatibility shims are small, so the cost-to-benefit ratio is high. :+1: from me.