search

someteam / acha

Git Achievements
http://acha-acha.co
Eclipse Public License 1.0
466 stars 33 forks source link

A workaround for null clone-url #27

Closed nLight closed 8 years ago

nLight commented 8 years ago

Hi guys,

sometimes for some commits clone-url is null and a user page can't be opened because of this. This is a workaround for this issue.

Best, Dima

avasenin commented 8 years ago

I will take a look into this in the next week. I'm on the trip right now

avasenin commented 8 years ago

Sorry for this delay. Totally forgot about this PR.

Could you provide a scenario when repo-url is null for you? We shouldn't get this situation at all. This issue means that you have commits for null repo. Need to check repos table in sqlite and repos in datascript to find the cause of this.

nLight commented 8 years ago

Unfortunately I can't provide the exact scenario. I don't really think that this issue can pop up under "normal" conditions. We've had some problems scanning our huge repos until we "upgraded" a VM which runs acha. Still, the most of the user pages were fine but some of them had this null issue. What is even more interesting: only some commits of a repo were affected not all of them. I will look into a db though I'm not sure if it's still there, we did full rescan after upgrade.