Broken ARIA reference + aria-label Object

somewebmedia / hc-offcanvas-nav

JavaScript library for creating toggled off-canvas multi-level navigations, allowing endless nesting of submenu elements, supporting swipe gestures, keyboard interactions and ARIA attributes.

https://somewebmedia.github.io/hc-offcanvas-nav/

MIT License

336 stars 82 forks source link

Broken ARIA reference + aria-label Object #55

Closed 5ulo closed 3 years ago

5ulo commented 3 years ago

The aria-labelledby="hc-nav-1" doesn't match anything in the DOM. This id should be attached as <h2 class="nav-title" id="hc-nav-1">

And the next problem is with page logo as a offcanvas title.. as it is object, it also renders as object inside aria-label and looks like aria-label="[object HTMLImageElement]"

Image says it all..

Screen Shot 2020-11-30 at 09 58 03

edit: aria-labelledby is broken in all submenus too

somewebmedia commented 3 years ago

Yeah I see now I messed up with the aria. It'll be fixed in the next release.

somewebmedia commented 3 years ago

It's properly (hope so) fixed in the latest release.