Do not increase parameter callback count when an existing callback is overwritten

someweisguy / esp_dmx

Espressif ESP32 implementation of ANSI-ESTA E1.11 DMX-512A and E1.20 RDM

MIT License

335 stars 35 forks source link

Do not increase parameter callback count when an existing callback is overwritten #88

Closed arneboe closed 1 year ago

arneboe commented 1 year ago

I stumbled upon this while reading the code :-) As far as I understand rdm_register_parameter allows for overwriting existing callbacks. In that case i would point to the existing callback and the number of callbacks should not increase. However the number of callbacks was always increased. This is fixed by this PR

someweisguy commented 1 year ago

Excellent find. Thank you for submitting this PR!