Use WordPress shortcodes to display product recommendations at any page or location of your WooCommerce store. Feature plugin for the official Product Recommendations extension.
2
stars
1
forks
source link
Released build is missing built CSS and JS files #9
The released 2.0.0 version of this plugin is missing the following built CSS and JS files:
assets/css/admin/wc-prl-cl-admin.css
assets/js/admin/wc-prl-cl-admin.js
This causes the those files to not load at runtime:
Which causes style issues and missing functionality:
Current (broken)
Arrows to move meta boxes are visible
Formatting issues in Shortcode meta box
Copy shortcode does not work (since JS did not load)
Fixed (local branch -- once I have access I will create PR)
Things look correct
Copy shortcode works
Underlying build/dev dependecies issue
I believe the underlying issue is that the build is out-of-date and not functioning correctly. At least, I could not build it on my local system. npm i fails due to out-of-date dependencies and missing python2.
Once I updated the dev dependencies to match those in the WooCommerce Product Recommendations repo, I was able to successfully build the project and the styles and functionality worked at runtime. (Rather than install python2 in an attempt to get things working, I think it is better to update the build for this project to be in-sync/up-to-date with the base plugin repo, since that is a better dev experience.)
PanosSynetos
commented
2 weeks ago
Description
The released
2.0.0version of this plugin is missing the following built CSS and JS files:assets/css/admin/wc-prl-cl-admin.cssassets/js/admin/wc-prl-cl-admin.jsThis causes the those files to not load at runtime:
Which causes style issues and missing functionality:
Current (broken)
Fixed (local branch -- once I have access I will create PR)
Underlying build/dev dependecies issue
I believe the underlying issue is that the build is out-of-date and not functioning correctly. At least, I could not build it on my local system.
npm ifails due to out-of-date dependencies and missingpython2.Once I updated the dev dependencies to match those in the WooCommerce Product Recommendations repo, I was able to successfully build the project and the styles and functionality worked at runtime. (Rather than install
python2in an attempt to get things working, I think it is better to update the build for this project to be in-sync/up-to-date with the base plugin repo, since that is a better dev experience.)