somexlab / fastddm

Python library for Differential Dynamic Microscopy analysis
https://fastddm.readthedocs.io/
GNU General Public License v3.0
3 stars 0 forks source link

Make package stable against CUDA updates #183

Closed enrico-lattuada closed 9 months ago

enrico-lattuada commented 9 months ago

Description CUDA Toolkit updates might break the links to DLLs in Windows. Make them more stable.

Proposed solution Add the CUDA Toolkit version to the _config.py file and read it to add the path in Windows.

Additional context See what pytorch does in the __init__.py:

...
cuda_version_1 = cuda_version.replace('.', '_')
cuda_path_var = 'CUDA_PATH_V' + cuda_version_1

and in the version.py.tpl (which is configured during install):

cuda = '{{CUDA_VERSION}}'

In our case, we want to use CUDAToolkit_VERSION, which is set by FindCUDAToolkit.

enrico-lattuada commented 9 months ago

Closed by #184