somini / Pixelvision2

Steam Skin created by Pulseh and continued by Mr Late
273 stars 32 forks source link

Layout busted under new chat beta #105

Closed flatluigi closed 5 years ago

Bluscream commented 6 years ago

I got no problems, please describe!

liznevada commented 6 years ago

probably because you are not on the latest beta. image

the details are here https://steamcommunity.com/updates/chatupdate

Bluscream commented 6 years ago

I just got the latest beta and the friends window isn't even opening...

NapoSky commented 6 years ago

Same here, you must restart steam after going here : https://steamcommunity.com/updates/chatupdate#tryit

image

somini commented 6 years ago

It seems Valve is migrating the chat to the web: https://steamcommunity.com/chat/

In that case, the skin will no longer control the UI.

Bluscream commented 6 years ago

Hmm so that means javascript/css would be required?

somini commented 6 years ago

Likely, but depending on the way it is done, it might be nigh-impossible to style.

If they use Web Components or one of those newfangled frameworks that uglify the CSS classes for performance (highly likely, but I haven't checked), it's game over.

NapoSky commented 6 years ago

Even the main UI can't be fixed ? I see Black4Blade try to do sth about this : https://github.com/Black4Blade/Pixelvision2/commit/45f403554005d6ed570613b6aa13144b55f5359e

SzymonNadbrzezny commented 6 years ago

@somini so you'll try to update pixelvision?

Bluscream commented 6 years ago

@NapoSky thanks for bringing that fork to my attention. Using that now :)

NapoSky commented 5 years ago

PR is passed : https://github.com/somini/Pixelvision2/pull/106 @mr-late should close this issue ;)

mr-late commented 5 years ago

Issue fixed, moving on.