search

somini / Pixelvision2

Steam Skin created by Pulseh and continued by Mr Late
273 stars 29 forks source link

No Steam Proton button #113

Closed ipkpjersi closed 5 years ago

ipkpjersi commented 5 years ago

As you can see in the top left corner of this picture, it says "runs" which means it runs using Steam Proton as I am on Linux, but there is no button for this:

halbrd commented 5 years ago

Would you be able to provide a screenshot of what it's supposed to look like (i.e. with the default Steam skin enabled) so we can understand what's not working properly?

ipkpjersi commented 5 years ago

Hi,

Sure, I can do that.

It should look like this for non-official Proton Compatible titles:

It should look like this for official Proton Compatible titles:

I hope this clears up any confusion.

Thanks.

Black4Blade commented 5 years ago

Hey I think I got it fixed If you can test it and let me know, it's not perfect at all, will need a little more work, and will need to get in order something else that may be there but just want to know if this does fix the basic problem https://github.com/Black4Blade/Pixelvision2/tree/BetaFastFix

@ipkpjersi

ipkpjersi commented 5 years ago

It's perfect for me, awesome! Nice job. Hopefully you can make a PR with these fixes and the PR gets merged.

Black4Blade commented 5 years ago

It's perfect for me, awesome! Nice job. Hopefully, you can make a PR with these fixes and the PR gets merged.

I can manage, got access, not doing it yet, mostly because need to word some things there better :P Besides that, it looks completely fine by you? by me it was squashed may have been because the VM was a low res

ipkpjersi commented 5 years ago

No resolution or stretching issues whatsoever. Looks perfect to me, but I can test it more later tonight.

edit: I tested it more, seems to be working perfectly fine for me even at various sizes etc.

Black4Blade commented 5 years ago

No resolution or stretching issues whatsoever. Looks perfect to me, but I can test it more later tonight.

edit: I tested it more, seems to be working perfectly fine for me even at various sizes etc.

thanks for testing I put a pull request with the fix, just have to make sure its not breaking something else that or any other fix I put there before its merged

Black4Blade commented 5 years ago

Ok merged this should be fixed now So closing this issue