search

somini / Pixelvision2

Steam Skin created by Pulseh and continued by Mr Late
273 stars 29 forks source link

Changed Download Bar #34

Open micah686 opened 9 years ago

micah686 commented 9 years ago

![Uploading new_download_bar.PNG . . .]()

Re-centered the downloads text, and moved the download progress bar down, while decreasing its height

CaptainMagma commented 9 years ago

Could you please provide a before and after picture and a reason for these changes? It would help a lot.

micah686 commented 9 years ago

old download bar new_download_bar Since the "X Online" button isn't at the bottom right anymore, I decided to recenter the downloading text. Also, I think the changes keep more to the pixelvision skin feel than the previous one.

CaptainMagma commented 9 years ago

Oh, I see what you mean. Although I don't disagree that it's a good idea, I don't think any of us (somini, mr. late, and myself) would agree to changing the way the skin looks from the way Pulseh had it in the first place. That being said, there's nothing stopping you from keeping it as your own personal mod since that file doesn't seem like one that gets updated often (last update for the uistatuspanel.layout was 11/11/2014).

Edit: On second thought, I don't think that's a very good reason to shoot down your idea, nor is it fair. Give me about a day and I'll think about it. Somini, I would like your opinion on this as well if you have one.

Edit2: Actually, I see now why this would not work. First off, the bottom portion of the screen does not really give you enough room to stack the download text on top of the download bar. It just looks a little too squished together, in my opinion, which makes it look a little less organized. Second, the thin black border of the download bar does not surround the blue bar entirely, but instead the bottom border runs off to the left a little too much (this is just a small problem that could probably be fixed easily).

Efreak commented 9 years ago

I think it looks decent enough, if you can fix the issue with it. If you're worried about changing the skin from what Pulseh wanted, you could also add it as a tweak that's disabled by default.

PS, you can prefix a username with @ (ie @CaptainMagma), and GitHub will linkify the username, and also tell the user they got mentioned.

somini commented 9 years ago

Yeah, I think making this a tweak, or even an Override, is the way to go. I'll investigate this further when I got the time.