search

somini / Pixelvision2

Steam Skin created by Pulseh and continued by Mr Late
273 stars 29 forks source link

Nickname UI display issue #39

Closed zirwin closed 9 years ago

zirwin commented 9 years ago

Steps to reproduce:

  1. Open the friends list
  2. Click the arrow near a friend
  3. Select "Add Nickname"

You'll be presented with this UI:

image

The input box overlaps the text label.

For what it's worth, this was also the case in old PixelVision, I'm not sure if this UI changed at some point.

somini commented 9 years ago

I can confirm this issue, but I can't really find where this screen is defined, git grep -i nick brings nothing.

Paging @CaptainMagma for help.

CaptainMagma commented 9 years ago

I'll be looking into this soon, thanks for the post.

Edit: Not really sure how this is supposed to be fixed at the moment. Especially since I don't even get that problem with my skin and the file that edits this panel isn't even included in PixelVision. Do you use increased font size?

somini commented 9 years ago

I do, +2. In the regular font size the problem still remains, though. Regular Size

CaptainMagma commented 9 years ago

What resolution do you use?

somini commented 9 years ago

1920*1080

CaptainMagma commented 9 years ago

@somini That doesn't look like the default font in your screenshot though. And are you on Windows?

somini commented 9 years ago

Linux actually. I did install the Segoe fonts, but Steam doesn't like to play ball with the rest of the system (#36).

CaptainMagma commented 9 years ago

Could you try it on the default Steam skin and tell me if you still have the same issue?

somini commented 9 years ago

It does, half way there between both screenshots in this thread.

CaptainMagma commented 9 years ago

Alright, well the fix should be fairly simple. All I've done is moved the text box down by 10 pixels and also increased its width because I noticed it doesn't look evenly centered in the screen. I'll be submitting the pull request in a few minutes.

Edit: Let me know if this fix looks fine with your font. I only tested it with default font settings.

somini commented 9 years ago

PR #40 fixed this, I'm closing this.

Feel free to comment or reopen in case there's some problem.