search

somini / Pixelvision2

Steam Skin created by Pulseh and continued by Mr Late
272 stars 29 forks source link

Added Phone Reminder Bar #48

Closed CaptainMagma closed 9 years ago

CaptainMagma commented 9 years ago

@neico could you please explain in greater detail why they need to be removed? I put them there because at the time, I didn't understand how to make the border stretch farther than the height of the emailreminderbar.

neico commented 9 years ago

Which are you referring to? the color ones?

Aynway, surely there was a reason to why things differ from the steam default (it's a skin after all), here's the relevant diff:

CaptainMagma commented 9 years ago

@neico Those three fill lines are not identical to the ones in the phonereminderbar.layout file because I replaced them with the PixelVision style border. Have you seen what the reminder bar looks like without those four lines? The PixelVision style gray and black border that surrounds it is incomplete on the bottom left and bottom right sides. Test it for yourself so you can see. I added that border because I didn't know if there was any other way to make the border stretch to the height of the reminder bar.

somini commented 9 years ago

Sorry for taking so long to answer this, I was away for this past few days.

I tested the last version, and it seems good to me. What's the actual conflict here?

CaptainMagma commented 9 years ago

Valve added a phone reminder bar in one of their latest Steam updates. Basically, it's a green pop-up that reminds you that you should add your phone number to Steam for extra security measures. I added and updated the files necessary in order for the pop-up to appear the way it should. Previously it appeared like this: http://i.imgur.com/3OU9m3x.png (image from bug report in PixelVision group discussions).

somini commented 9 years ago

Yeah, I got that today and (hapilly :D) verified there was a patch already available. I was just asking if the discussion with @neico has reached a conclusion, it kinda ends abruptly...

somini commented 9 years ago

Well, I tested it and it works, so I'm merging this, people are complaining loudly in that thread.

If @neico has any more comments, feel free to comment on this issue.