search

somini / Pixelvision2

Steam Skin created by Pulseh and continued by Mr Late
273 stars 29 forks source link

Family View errors #50

Open somini opened 8 years ago

somini commented 8 years ago

As reported on the Steam Forum http://steamcommunity.com/groups/pixelvision2/discussions/0/523897653306957927/

Here's a screenshot: ss

I dug into the code and I see "ParentalLockButton" it's defined here: https://github.com/somini/Pixelvision2/blob/master/resource/layout/steamrootdialog.layout#L620

I changed the margin-right to 75 and got this. When Parental Control is active, there's a small discrepancy in the username. screenshot from 2015-09-19 15 31 04

CaptainMagma commented 8 years ago

Unfortunately, I won't be able to look into this issue until either late tonight or tomorrow. I have a lot of work that I planned on completing today. If the issue has not been resolved by tonight, expect a pull request from me some time tomorrow in the afternoon.

CaptainMagma commented 8 years ago

When I enable family view with default settings on PixelVision, the icon is in the correct position. Are you sure this error in positioning is not a result of switching fonts?

somini commented 8 years ago

Could be, I use the +3 font size tweak.

CaptainMagma commented 8 years ago

Oh I see how this bug is happening. If you have no money in your Steam wallet, it doesn't get aligned right. I'll have a fix for this shortly.

somini commented 8 years ago

A new issue has cropped up, so I'm reopening this: bug When the wallet balance is too big, the Family View button overlaps it. It should be a matter of moving the button a dozen pixels to the left.

CaptainMagma commented 8 years ago

The location of the family view button does not change dynamically. The only thing I could do was change its static location. Since this is still a problem, all you can do is move further along the left or relocate it. You can try different locations if you want. I don't have time to look at this right now, sorry. This weekend I should be able to look at all the issues so far.

Black4Blade commented 3 years ago

Hey, can this topic be closed now seeing that they changed how the account balance and all is showing? I will assume that will solve the issue for the wallet crashing into it (I don't have that much in my currency to see if it will clash, no idea if there is a way to fake add there)

Bluscream commented 3 years ago

https://github.com/somini/Pixelvision2/issues/50#issuecomment-155587536

Sadly this will never happen to me ;c