somini / Pixelvision2

Steam Skin created by Pulseh and continued by Mr Late
273 stars 29 forks source link

Re-Align Family View Button #51

Closed CaptainMagma closed 8 years ago

CaptainMagma commented 8 years ago

Everything works on my end after testing the fix. Let me know if anything else needs to be fixed (please test with PixelVision default settings).

somini commented 8 years ago

Hmm, I still got some issues. Tested by checking out the pull/51 branch. Family View off screenshot from 2015-09-22 21 51 58 Family View on screenshot from 2015-09-22 21 51 43 I'd use margin-right: 60 for a little extra headroom, but where is the other misalignment coming from?

CaptainMagma commented 8 years ago

You tested on PixelVision default settings? That doesn't look like the default font.

somini commented 8 years ago

It's the Linux client font bug then.

If you can send me a screenshot of the Windows version I'll merge this.

CaptainMagma commented 8 years ago

I don't know if the font is to blame or not. I was just unsure as to whether or not you were on default settings since the font was different. I'll have to look into this some more later on this week. There's no rush. It's a small bug and I don't have much free time right now.

somini commented 8 years ago

Very well, take your time. It's a cosmetic bug anyway.

CaptainMagma commented 8 years ago

One last thing: could you tell me what features you have enabled/disabled for family view?

somini commented 8 years ago

I left all the options ticked off, it's the least amount of access possible.

CaptainMagma commented 8 years ago

Yea, after doing that, I now have the same problem you are having. Thanks for the feedback. I'll be looking into this later in the week.

CaptainMagma commented 8 years ago

This last edit should fix the alignment issue with the account url when it's disabled. As for the margin of the Family View icon, I chose to leave it at 50 because it was already farther to the left than it was before I submitted this pull request. I think the font bug that you have is causing the Family View icon to align too close.

somini commented 8 years ago

Yup, it's fixed now, thanks for the quick response. I think I'll merge this so that it's easier to test.