search

somini / Pixelvision2

Steam Skin created by Pulseh and continued by Mr Late
273 stars 32 forks source link

Bring "Display download rates in bits per second" checkbox into view #69

Closed clevelandj closed 8 years ago

clevelandj commented 8 years ago

Valve recently added "an option to display download speeds as bits per second (Mbps) instead of MB/sec, for easier comparison with the way network and internet connection speeds are traditionally reported": http://store.steampowered.com/news/20748/

This new option is currently hidden in Pixelvision2 due to the default margin-top values in Steam's resource/layout/subpaneloptionsdownloads.layout file. This pull request adds the subpaneloptionsdownloads.layout file to Pixelvision2 so that we can override the margin-top values in order to get the new option to show up. I modified the divider-related margin-top values from "15" to "10" as compared to Steam's file.

somini commented 8 years ago

Many thanks for the PR.

I'm on Linux, so while testing this I noticed I couldn't see that checkbox anyway. It's probably due to font issues, not a problem with your PR. I poked around and added about 100px to the settings window, that should be future-proof.

If you can test the https://github.com/somini/Pixelvision2/tree/pull/69 branch on Windows successfully, I'll merge this.

bykidi commented 8 years ago

PR default

master default

somini commented 8 years ago

For completeness, this PR on Linux. screenshot from 2016-03-11 00 24 10

In that case, I'll merge this then. Many thanks to @clevelandj for the PR and @bykidi for testing.