Open mr-late opened 8 years ago
somini
commented
8 years ago Can you rebase this to the latest master? What is the actual commit that fixes the issue? This introduces loads of commits that were already merged.
If you're not sure how to do it, I can sort it out myself, but it will take a while.
mr-late
commented
8 years ago Yeah sorry about that, still a newbie with Github. The changed files are 'about_version.tga' 'Change Log.txt' and 'screenshotmanager.layout'
commit codes are 3abfc2b, 4c5430a, a024883
somini
commented
8 years ago I've merged your commits (branch pull/77), but I got the upload and delete button aligned on top.
I tried to put some align="bottom-right" on the screenshotmanager file, but it didn't work.
mr-late
commented
8 years ago Crap, I got it fixed now, for real.
Line 321 should look like: place { control="null_placer" region="details" width=-1 align=bottom-left margin-bottom=5 } 322: place { control="spoiler_checkbox" start="null_placer" region="details" align=bottom margin-bottom=30 margin-right=7 spacing=5 } 323: place { control="delete_button,details_button,publish_button" start="null_placer" region="details" align=right x=5 margin-bottom=9 margin-right=1 margin-top=312 spacing=5 }
This was a quick and ugly hack though, so it might bite in the ass later.
somini
commented
8 years ago Yup, it only works for the smallest possible window size, if you resize the windows the buttons stay put. I aligned to the bottom and try to center it. It's basically impossible to fix it this way, since there's two different sizes, whether the screenshot is uploaded or not. It's better if we try to solve it in some other way, but it seems that align="bottom-right" is bugged.
I pushed my changes (and yours) to the pull/77 branch, please test.
This should fix the issues that are mentioned in #76