search

somm15 / PyViCare

Python Library to access Viessmann ViCare API
Apache License 2.0
130 stars 84 forks source link

Expose circuit name, status and type #340

Closed CFenner closed 7 months ago

fb22 commented 7 months ago

I would add 'circuit' to the function name: getCircuitActive, getCircuitName, getCircuitType

CFenner commented 7 months ago

I omitted that as no other function has the object type in the name. Also e.g. burners do not have a prefix:

https://github.com/somm15/PyViCare/blob/e988a38de90f65c943f1a2de08b31d5f9646b7df/PyViCare/PyViCareFuelCell.py#L339

fb22 commented 7 months ago

you're right