search

somsak / microblog-purple

Automatically exported from code.google.com/p/microblog-purple
GNU General Public License v3.0
2 stars 1 forks source link

Respect user defined LDFLAGS during make #226

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. make LDFLAGS=...

What is the expected output? What do you see instead?
 I test by calling "make LDFLAGS=breakLD" which sould break the build. But it dous not.

What version of the product are you using? On what operating system?
 Version is 0.3.0 on gentoo

Please provide any additional information below.
 sed -r '/^LDFLAGS/s:=:= $(LDFLAGS):' -i global.mak should fix the problem.

Original issue reported on code.google.com by andresen.nils@gmail.com on 15 Jan 2011 at 7:24

GoogleCodeExporter commented 9 years ago 
Staring at the line in which you construct LDFLAGS, I am unsure why is is this 
way. So:
 sed -i "/^LDFLAGS/d" global.mak should fix the problem, too...

Original comment by andresen.nils@gmail.com on 16 Jan 2011 at 9:00

GoogleCodeExporter commented 9 years ago 
I added a patch to fix this issue. I'd love to have some comment on it.

Original comment by andresen.nils@gmail.com on 4 Feb 2011 at 6:18

Attachments:

GoogleCodeExporter commented 9 years ago 
Patch merged into SVN

Original comment by somsaks on 7 Feb 2011 at 9:22