somts / odf-ctd-proc

ODF CTD processing c. 2016
BSD 3-Clause "New" or "Revised" License
8 stars 7 forks source link

Updated readme, install files, minor code cleanups #12

Closed webbpinner closed 6 years ago

webbpinner commented 7 years ago

I saw this project was being worked on again and took a look to see how things have changed. I forked the project again and tried to add some changes to improve use by other groups.

I hope these changes were seen as helpful to the project.

asx- commented 7 years ago

Hi Webb,

We're currently in the process of big architectural change right now, both in code and in organizationally. I can't accept any PRs right now since there's a lot of discussion about how we want to shape and restructure this project for the future. Once some things settle down organizationally and we can get some basic standards documents in place, we'll be open for PRs again.

Quick comments on the code: Although it's not in place yet, we want to get away from any print/debugPrint statements and move completely to the logging module. CSV primarily served as the interchange format first, data inspection second. That format will most likely change away from pickle towards netCDF via xarray when we're not making urgent patches to the code to keep things running, which requires having a routine to read netCDF, but will be much easier to support than CSV.

webbpinner commented 7 years ago

Thanks for the reply and explanation. I do agree this size of this project now warrants a redesign.

I'm encountering more and more users that have a need for a library/tool that can enable them to develop semi-automated processing of SBE data files.

Please let me know if there's anything I can do to help.

asx- commented 6 years ago

Closing this for now because I think enough change has happened to package structure, files to require a serious update that would be better dealt with after the architecture settles down more. Will revisit in January 2018