son-link / minimal-podcasts-player

Subscribe, listen and (in the future) download your favorite podcasts, quickly and easily.
GNU General Public License v3.0
17 stars 4 forks source link

Default to system theme #3

Closed probonopd closed 3 years ago

probonopd commented 3 years ago

Please default to system theme theme = system and make the "System" selectable in the configuration window.

Most users want applications to look "native", and to follow the look and feel of the rest of the system (buttons, fonts, colors, etc.). In my example:

son-link commented 3 years ago

I am working on it. At first there was no option to select a theme, but seeing that in both Windows and an .AppImage it defaulted to the Fusion theme I decided to look for some themes to use in both, but I couldn't get it to switch back to the system theme except by restarting the program. I think that's the only way, so if I see that it changes from a qt-material theme to the system theme it should show a warning message about it, and if it accepts, restart.

probonopd commented 3 years ago

This solves it for me: https://github.com/son-link/minimal-podcasts-player/pull/4

Personally I think Material Design only belongs onto Android devices, where it is the native theme.

son-link commented 3 years ago

In the last commit this option is only available for Windows and .AppImage , but need some testing on boot

probonopd commented 3 years ago

Thanks @son-link.

Unfortunately the problems are back:

image

son-link commented 3 years ago

Ok, i use a function for detect the system. Just i installed Hello on Virtual Machine on VirtualBox just for testing

probonopd commented 3 years ago

It seems like the standard colors of the system are ignored. Compare to the "Keyboard Layout" window: there the selected item font is white, which is much more readable on the black background.

image

son-link commented 3 years ago

In the next release i remove qt-material and replace the icons for Breeze icons for use on Windows and the AppImage.

probonopd commented 3 years ago

And for other OSes, such as FreeBSD?

son-link commented 3 years ago

And for other OSes, such as FreeBSD?

On FreeBSD uses the system theme, as in Linux