Closed shwabnitz closed 5 years ago
Can we help to fix this?
Since there is a new comment in this issue.
I tried to make this module work with jhipster 6.1.2. Got a half working update. But I think there is too many problems with the current implementation:
So I decided to convert it into a jhipster blueprint. To not conflict with current module, changed the name to multitenancy2. If the generator-jhipster-multitenancy maintainer want, feel free to adopt the repository. https://github.com/mshima/generator-jhipster-multitenancy2
Nice work! We'd had been looking at rewriting as a blueprint so this is great. If it's ok with you we'll review the code to understand it and then merge into the project. How does that sound?
Nice work! We'd had been looking at rewriting as a blueprint so this is great. If it's ok with you we'll review the code to understand it and then merge into the project. How does that sound?
Feel free to do it, but I think is better to create another project (multitenancy2) than merging into multitenancy to avoid conflicts.
Hi ,
Look really good, but the latest commit broke the build. Is it hard to fix that?
Kind regards,
Barry Vredevoort
On 18 Jul 2019, at 21:56, mshima notifications@github.com wrote:
Since there is a new comment in this issue.
I tried to make this module work with jhipster 6.1.2. Got a half working update. But I think there is too many problems with the current implementation:
Cannot recreate the project (update jhipster version) Bugs on tenant aware entity creation. Too complicated. So I decided to convert it into a jhipster blueprint. To not conflict with current module, changed the name to multitenancy2. If the generator-jhipster-multitenancy maintainer want, feel free to adopt the repository. https://github.com/mshima/generator-jhipster-multitenancy2 https://github.com/mshima/generator-jhipster-multitenancy2 JHipster = 6.1.2 tested for now, < 6 not working. protractor not fixed yet. work in progress. — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sonalake/generator-jhipster-multitenancy/issues/56?email_source=notifications&email_token=AAZ65ZB2TL5RLHCCREJQHUDQADDGTA5CNFSM4HMGDRPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2JTJ4A#issuecomment-512963824, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZ65ZFYUBMPXKFIDGHP67TQADDGTANCNFSM4HMGDRPA.
Hi , Look really good, but the latest commit broke the build. Is it hard to fix that? Kind regards, Barry Vredevoort … On 18 Jul 2019, at 21:56, mshima @.***> wrote: Since there is a new comment in this issue. I tried to make this module work with jhipster 6.1.2. Got a half working update. But I think there is too many problems with the current implementation: Cannot recreate the project (update jhipster version) Bugs on tenant aware entity creation. Too complicated. So I decided to convert it into a jhipster blueprint. To not conflict with current module, changed the name to multitenancy2. If the generator-jhipster-multitenancy maintainer want, feel free to adopt the repository. https://github.com/mshima/generator-jhipster-multitenancy2 https://github.com/mshima/generator-jhipster-multitenancy2 JHipster = 6.1.2 tested for now, < 6 not working. protractor not fixed yet. work in progress. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#56?email_source=notifications&email_token=AAZ65ZB2TL5RLHCCREJQHUDQADDGTA5CNFSM4HMGDRPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2JTJ4A#issuecomment-512963824>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZ65ZFYUBMPXKFIDGHP67TQADDGTANCNFSM4HMGDRPA.
I tried to fix github security alert. Reverted the dependency update.
Thank you all for your work on that issue in the past 3 months. Unfortunately, I do not get multitenancy2 working, I assume due to a lack of an entry in npm repo: https://www.npmjs.com/package/generator-jhipster-multitenancy2 nor yarn repo.
What's the plan for the future? Is the merge of multitenancy2 into this project still on the roadmap or do you plan a native support of jhipster >= 6, will multitenancy2 replace this multitenancy or anything else?
Kind regards Sven
Thank you all for your work on that issue in the past 3 months. Unfortunately, I do not get multitenancy2 working, I assume due to a lack of an entry in npm repo: https://www.npmjs.com/package/generator-jhipster-multitenancy2 nor yarn repo.
Have you tried:
npm install git+https://git@github.com/mshima/generator-jhipster-multitenancy2.git
jhipster --blueprint multitenancy2
What's the plan for the future? Is the merge of multitenancy2 into this project still on the roadmap or do you plan a native support of jhipster >= 6, will multitenancy2 replace this multitenancy or anything else?
There a copy of it:
https://github.com/sonalake/generator-jhipster-multitenancy/tree/develop
But is missing some commits for now.
Can be installed by:
npm install generator-jhipster-multitenancy#develop
Thank you all for your work on that issue in the past 3 months. Unfortunately, I do not get multitenancy2 working, I assume due to a lack of an entry in npm repo: https://www.npmjs.com/package/generator-jhipster-multitenancy2 nor yarn repo.
Have you tried:
Thank you for your answer.
npm install git+https://git@github.com/mshima/generator-jhipster-multitenancy2.git jhipster --blueprint multitenancy2
I tried, got the following error: Unable to find src/test/java/undefined/service/MailServiceIT.java or missing required jhipster-needle. LANGUAGE constant not updated with languages: en since block was not found. Check if you have enabled translation support.
info Using blueprint generator-jhipster-multitenancy2 for entity-server subgenerator
info Using blueprint generator-jhipster-multitenancy2 for entity-client subgenerator
events.js:170 throw er; // Unhandled 'error' event ^
Error: The generator-jhipster-multitenancy2 blueprint provided is not installed. Please install it using command npm i -g generator-jhipster-multitenancy2. at Environment.error (/home/shwabnitz/.npm/lib/node_modules/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:176:40) at module.exports.error (/home/shwabnitz/.npm/lib/node_modules/generator-jhipster-multitenancy2/node_modules/generator-jhipster/generators/generator-base.js:1448:18) at shelljs.exec (/home/shwabnitz/.npm/lib/node_modules/generator-jhipster-multitenancy2/node_modules/generator-jhipster/generators/generator-base-private.js:839:22) at /home/shwabnitz/.npm/lib/node_modules/generator-jhipster-multitenancy2/node_modules/generator-jhipster/node_modules/shelljs/src/exec.js:127:9 at ChildProcess.exithandler (child_process.js:306:5) at ChildProcess.emit (events.js:193:13) at maybeClose (internal/child_process.js:999:16) at Socket.stream.socket.on (internal/child_process.js:403:11) at Socket.emit (events.js:193:13) at Pipe._handle.close (net.js:614:12) Emitted 'error' event at: at Environment.error (/home/shwabnitz/.npm/lib/node_modules/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:178:15) at module.exports.error (/home/shwabnitz/.npm/lib/node_modules/generator-jhipster-multitenancy2/node_modules/generator-jhipster/generators/generator-base.js:1448:18) [... lines matching original stack trace ...] at Pipe._handle.close (net.js:614:12)
What's the plan for the future? Is the merge of multitenancy2 into this project still on the roadmap or do you plan a native support of jhipster >= 6, will multitenancy2 replace this multitenancy or anything else?
There a copy of it: https://github.com/sonalake/generator-jhipster-multitenancy/tree/develop But is missing some commits for now. Can be installed by:
npm install generator-jhipster-multitenancy#develop
Here I got the error: npm install generator-jhipster-multitenancy#develop npm ERR! code EINVALIDTAGNAME npm ERR! Invalid tag name "generator-jhipster-multitenancy#develop": Tags may not have any characters that encodeURIComponent encodes.
@shwabnitz, you are right, try the following:
npm install generator-jhipster@6.1.2
npm install mshima/generator-jhipster-multitenancy2#master
jhipster --blueprint multitenancy2
jhipster --with-entities --blueprint multitenancy2
The first run will not compile successfully because of jhipster bugs.
Last commit should work with 6.2.0
npm install generator-jhipster@6.2.0
npm install mshima/generator-jhipster-multitenancy2#master
jhipster --blueprint multitenancy2
jhipster --with-entities --blueprint multitenancy2
The second jhipster generator with have some changes too.
Last commit should work with 6.2.0
npm install generator-jhipster@6.2.0 npm install mshima/generator-jhipster-multitenancy2#master jhipster --blueprint multitenancy2 jhipster --with-entities --blueprint multitenancy2
The second jhipster generator with have some changes too.
Thank you very much. It compiles with 6.2.0, starts and I am able to login. I will perform some more tests the next days.
I created some more issues for https://github.com/mshima/generator-jhipster-multitenancy2. It seemed more appropriate to me to place them there.
@mshima Amazing stuff! Thank you for the fast and excellent fixes of the issues in https://github.com/mshima/generator-jhipster-multitenancy2.
Closing issue as module has been converted to a blueprint which now supports JHipster 6.0.0
Hi,
I installed / updated Jhipster and got the error: "Your generated project used a JHipster version (6.0.0) that is currently not supported.".
When will it be supported?
Thank you!