sonarwatch / portfolio

SonarWatch portfolio repository
https://sonarwatch.github.io/portfolio/
Mozilla Public License 2.0
52 stars 30 forks source link

integrated saber #1

Closed UbermenschSYM closed 1 year ago

UbermenschSYM commented 1 year ago

Integrated saber-lp-tokens job for OPOS hackaton ez

olivbau commented 1 year ago

Feel free to look at the commits Some notes:

But apart from that everything else is okay! Well done!

I'll fully test the job later today and then merge

UbermenschSYM commented 1 year ago

Maybe modify runInBatch to cache.getTokenPrices in other jobs as well?(raydium-lp-tokens for example). Or is there any reason why cache.getTokenPrices is better in this case? Great feedback, thanks!

olivbau commented 1 year ago

Maybe modify runInBatch to cache.getTokenPrices in other jobs as well?(raydium-lp-tokens for example). Or is there any reason why cache.getTokenPrices is better in this case? Great feedback, thanks!

at that time getTokenPrices was not dev yet. but yes, we'll have to migrate

olivbau commented 1 year ago

BTW price was not correct https://github.com/sonarwatch/portfolio/pull/1/commits/f7bf2ac1fa4ccc90d72510b6d4b062c8991e7b72

UbermenschSYM commented 1 year ago

True. mb