several bug fixes and updates

sonata-nfv / son-emu

Attention! Legacy! This repo will be replaced with https://github.com/containernet/vim-emu

https://github.com/containernet/vim-emu

Apache License 2.0

36 stars 32 forks source link

several bug fixes and updates #216

Closed stevenvanrossem closed 7 years ago

stevenvanrossem commented 7 years ago

extra information on the dashboard (ip addresses and interface names and placement graph)
fix compatibility issues with the editor
fix bugs related to the external SAP configuration

mpeuster commented 7 years ago

Hi, I added some comments to dummygatekeeper.py and sonata_simple_topology.py. In my view it does not make sense to change default values in these files because it will break old demos and make their documentation inconsistent.

If other default values are needed for a specific demo, they shall only be overwritten in this demo, e.g., create another topology file for it instead of changing existing ones.

Can we change this before merging?

stevenvanrossem commented 7 years ago

sorry, I merged too quickly, before reading the comments... These changes slipped in there for showing things at the demo for the softnetworking conference. I will create a new topology example and put back default values in the dummygatekeeper.

mpeuster commented 7 years ago

No problem. Just change back the two files.