search

sonata-nfv / son-emu

Attention! Legacy! This repo will be replaced with https://github.com/containernet/vim-emu
https://github.com/containernet/vim-emu
Apache License 2.0
36 stars 32 forks source link

Fix VLAN range of setChain from 1 to 4094 #239

Closed fruffy closed 7 years ago

fruffy commented 7 years ago

We are using the Sonata emulator to allocate a multitude of vnf chains (up to 40). However, we have been noticing that the first allocated chain always fails in a VLAN setup. The reason is that it received the VLAN tag 0, which is generally reserved. After modifying the net.py source code to only consider a VLAN range from 1 to 4094 (802.1Q Standard 5.3.1), all chains operate successfully.

sonata-jenkins commented 7 years ago

Can one of the admins verify this patch?

mpeuster commented 7 years ago

Thanks @FRuffy for your contribution. You mentioned a totally valid point with the VLAN range. I'll trigger Jenkins and merge the PR once the tests are completed.

Thanks again and let us know if you have other questions/problems.

mpeuster commented 7 years ago

close and re-open to trigger Jenkins ....

mpeuster commented 7 years ago

test this please

mpeuster commented 7 years ago

@FRuffy sorry there is an issue with the installation script that came up this morning (an external dependecy (Python requests) changed and causes Jenkins to fail. Let me fix this before I accept your PR.