sonata-nfv / son-gkeeper

SONATA's Service Platform Gatekeeper
http://www.sonata-nfv.eu
Apache License 2.0
2 stars 18 forks source link

Include debugging level in the configuration file #415

Closed jbonnet closed 7 years ago

jbonnet commented 7 years ago

Debugging level (:debug) is currently hardcoded, and should be configurable.

jbonnet commented 7 years ago

Closed by #416

felipevicens commented 7 years ago

@jbonnet Could we pass the option through container ENV variables?

felipevicens commented 7 years ago

@jbonnet I've notice that you create a text-plain file for the logs generated by the application. Theses logs are stored inside the container consuming disk resources. What do you think if we centralize the logs in a folder and mount a external volume to store it? by this way we can rotate this logs and from the point of view IT Operations would be simple to read the logs in the local server folder as /var/log/sonata/son-gk***.log On the other hand, can we create duplicate the logging output and save it in a file that is a simbolic link to /dev/stdout? by this way if the Platform Operator decide to use a centralize logging system will be able to do it because all the logs will be redirected to standard docker logging system.

jbonnet commented 7 years ago

Hi, @felipe,

It is already by ENV variable LOGGER_LEVEL, defaulting to ‘debug’.

On 20 Feb 2017, at 07:00, Felipe Vicens notifications@github.com wrote:

@jbonnet https://github.com/jbonnet Could we pass the option through container ENV variables?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sonata-nfv/son-gkeeper/issues/415#issuecomment-281002437, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAuQ6HZKtRoe8vNECTKEKNzUq9GhR3tks5reToWgaJpZM4MEbXC.

jbonnet commented 7 years ago

Sure, @felipevicens, But I didn’t understand the requirement; do you want to

1. log to the stdout?
2. log to /var/log/sonata/son-gk***.log?
3. both?

Thanks,

On 20 Feb 2017, at 07:22, Felipe Vicens notifications@github.com wrote:

@jbonnet https://github.com/jbonnet I've notice that you create a text-plain file for the logs generated by the application. Theses logs are stored inside the container consuming disk resources. What do you think if we centralize the logs in a folder and mount a external volume to store it? by this way we can rotate this logs and from the point of view IT Operations would be simple to read the logs in the local server folder as /var/log/sonata/son-gk***.log On the other hand, can we create duplicate the logging output and save it in a file that is a simbolic link to /dev/stdout? by this way if the Platform Operator decide to use a centralize logging system will be able to do it because all the logs will be redirected to standard docker logging system.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sonata-nfv/son-gkeeper/issues/415#issuecomment-281005405, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAuQ4Sbb1gu8QEAth0sdqu8l6aja2jsks5reT8jgaJpZM4MEbXC.

felipevicens commented 7 years ago

@jbonnet Should be option 3. both

jbonnet commented 7 years ago

Sure, @felipevicens, opening a new issue (#420)