Required fields [name, vendor] not present in the schema. nsr-schema

[felipevicens]

I notice that the nsr have some fields that are required but not defined in the structure. I have some problems in the nsr validation.

Please have a look here: https://raw.githubusercontent.com/sonata-nfv/son-schema/master/service-record/nsr-schema.yml

At the end

required: 
  - vendor 
  - name

We can delete it, I’m not sure if we need it.

What do you think?

[jbonnet]

@felipevicens Vendor and name should be the same as those in the VNFD the NSR comes from, right?

[felipevicens]

Is this information enough relevant to duplicate it between nsd and nsr?

In the vnfd is present but in the vnfr isn't.

[jbonnet]

@felipevicens I think we need a 'link' between the VNFD and the VNFR. One possibility is to use the VNFD UUID (it's already stored in the DB). This is the 'DB' approach I'm more used to. Another approach is to use the 'human-readable' unique identification, with the trio vendor-name-version.

[adrian-rosello]

I think NSR already has a field called "descriptor_reference", which is used to link NSR with the NSD it comes from. I think we can include the human-readable trio (vendor-name-version) but I wouldn't make it mandatory.

[mbredel]

+1

As much as I love the trio in the NSD/VNDF/PD, I think the NSR can live without it.

@felipevicens You are right about the required fields. I will remove them, but add the "Id" field as required. Is that ok?

[felipevicens]

@mbredel Yes That's perfect. id as UUID format.

Thanks Michael

[mbredel]

Done. Can it be closed?

[felipevicens]

@mbredel Hello! I'm checking it. I'll close when I finish.

Thanks Michael

[felipevicens]

It's OK now.