search

sonata-nfv / tng-sdk-package

The 5GTANGO SDK tool to create and unpack 5GTANGO packages.
http://www.5gtango.eu
Apache License 2.0
7 stars 9 forks source link

Add health check endpoint `/ping` to service mode #54

Closed mpeuster closed 6 years ago

mpeuster commented 6 years ago

https://git.cs.upb.de/5gtango/UserStories/issues/291

endpoint: /api/v1/ping

mpeuster commented 6 years ago

We don't have a fixed standard yet. tng-sdk-package will return HTTP status 200 with a body like this:

{
    "ping": "pong",
    "uptime": "b'14:28  up 18 days,  4:32, 13 users, load averages: 2.89 2.90 2.99\\n'"
}
jbonnet commented 6 years ago

Oh, but we do: just return 200 ok, body is ignored...I wonder if the ed point should be plural, for consistensy...?Em 04/05/2018 13:29, Manuel Peuster notifications@github.com escreveu:We don't have a fixed standard yet. tng-sdk-package will return HTTP status 200 with a body like this: { "ping": "pong", "uptime": "b'14:28 up 18 days, 4:32, 13 users, load averages: 2.89 2.90 2.99\n'" }

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

mpeuster commented 6 years ago

Exactly only 200 in mandatory, body can be anything. This is what I had in my mind. Having the uptime there is fun I think :-)

Plural is also fine with me. Can be easily changed. Just "ping" me ;-)