sonata-nfv / tng-sdk-project

The 5GTANGO SDK tool to manage network service projects.
http://www.5gtango.eu
Apache License 2.0
5 stars 4 forks source link

Validation error with example project #99

Closed stefanbschneider closed 5 years ago

stefanbschneider commented 5 years ago

I'm getting an validation error that I don't understand when running

tng-validation --project example-project 

on the example project defined in the tng-sdk-project repo: https://github.com/sonata-nfv/tng-sdk-project/tree/master/example-project

The error is

2019-08-16 14:44:39 nb-stschn tango.validator.events:l50 ERROR Undefined connection point
2019-08-16 14:44:39 nb-stschn tango.validator.events:l64 ERROR Function descriptor (VNFD) of vnf_id='vnf1' declared in connection point 'vnf1' in virtual link 'input' is not defined

I don't get what the error message is referring to. there is no connection point vnf1 referenced in the vnfd: https://github.com/sonata-nfv/tng-sdk-project/blob/master/example-project/tango_vnfd0.yml I also don't see any other issue with the descriptor

Not sure, who's currently working on the validator and could help me out with this? @MiguelRivasQuobis @anapolg

anapolg commented 5 years ago

Hi @stefanbschneider one question:

How do you define virtual links between vnf1 and vnf2 in tango_nsd when you only have one function defined in the service which is vnf0? Am I missing something in there?

Also in tango_vnfd0, you have several CPs which I am not sure they have the right type. For example, the mgmt one in the defined CDU has type internal. I would say it should be management. Anyway, I do not think that will give you an error if you consider all the connected CPs as the same type. You should review that part cause I find it messy changing the type between each end of the virtual link.. not sure if that is correct.

stefanbschneider commented 5 years ago

You're right, the thing with the VNFs in the NSD is weird - I'll have a look! Thanks for the hint