search

sonata-nfv / tng-sdk-validation

The 5GTANGO SDK validation repository
Apache License 2.0
2 stars 6 forks source link

Improve error feedback returned by custom rule validation #84

Closed antonroman closed 5 years ago

antonroman commented 6 years ago

The feedback provided by the custom rule validation it's a bit poor now. We should improve it to return as much information as possible in order to make debugging tasks easier.

anapolg commented 5 years ago

Test the output returned by the validator and check if it is understandable enough. Paste in here an example of the output and mention @antonroman or @anapolg to provide support.

MiguelRivasQuobis commented 5 years ago

Currently the errors are shown with the following format. Is it enough or we need to enhance the information? @antonroman @anapolg 

2019-06-13 12:07:32 [ERROR] [tngsdk.validation.custom_rules.validator_custom_rules] Custom error in descriptor 'eu.sonata-nfv.firewall-vnf.0.3' in vdu_id = 'vdu01'
The number of CPUs must be higher than 2!
2019-06-13 12:07:32 [ERROR] [tngsdk.validation.custom_rules.validator_custom_rules] Custom error in descriptor 'eu.sonata-nfv.firewall-vnf.0.3' in vdu_id = 'vdu01'
The size of RAM must be higher than 4GB!
anapolg commented 5 years ago

The information is enough. Please @MiguelRivasQuobis close this issue.