sonata-nfv / tng-vnv-planner

5GTANGO V&V Platform Planner repository
Apache License 2.0
3 stars 8 forks source link

Wrong coupling of TEST / NS #187

Closed sinaure closed 4 years ago

sinaure commented 4 years ago

uploaded 1 couple of Test / NS https://github.com/sonata-nfv/tng-tests/tree/master/tests/VnV/vnv-onboarding-phase

https://github.com/sonata-nfv/tng-tests/blob/master/packages/NSINDP1C/project.yml https://github.com/sonata-nfv/tng-tests/blob/master/packages/TSTINDP/project.yml

The instantiation results in 2 test plans instead of one. tng-smpilot-ns1-emulator.eu.5gtango.0.1 has no reference to tag

so it should not be executed

test-industrial-pilot-ns1.eu.5gtango.egm.1.1 tng-smpilot-ns1-emulator.eu.5gtango.0.1 Wed, 11 Dec 2019 11:13:50 GMT Scheduled    
test-industrial-pilot-ns1.eu.5gtango.egm.1.1 tng-smpilot-ns1-k8s.eu.5gtango.0.1 Wed, 11 Dec 2019 11:13:50 GMT Scheduled

Can this be a package versioning related problem?

santiagordguez commented 4 years ago

did you check this tng-smpilot-ns1-emulator.eu.5gtango.0.1?

imagen

santiagordguez commented 4 years ago

As you can see, the testing tag matches with industrial-pilot-broker

tng-cli -u http://pre-int-vnv-bcn.5gtango.eu package -g 919f1e00-dc4b-458b-82d4-1b7d23ca2cfe

created_at: '2019-12-03T13:20:25.052+00:00' md5: 2805e1115ed6dc0aa813ca9e6aa4736b pd: description: 'Smart manufacturing pilot: Factory edge service (NS1) for vim-emu.' descriptor_schema: https://raw.githubusercontent.com/sonata-nfv/tng-schema/master/package-specification/napd-schema.yml maintainer: Manuel Peuster (Paderborn University) name: tng-smpilot-ns1-emulator package_content:

sinaure commented 4 years ago

ok but this is the emulator test pd... what is unclear is: every time there is a change in a package do I need to upgrade the version? What happen if this is not removed? @tsoenen

santiagordguez commented 4 years ago

It's a good practice to use versioning but in this case it doesn't solve the multiple pairs. As you mentioned, if you have several versions uploaded with the same testing tags they will produce multiple testing pairs

tsoenen commented 4 years ago

We can remove the emulator package, because on the VnV, everything is tested against the k8s package.

sinaure commented 4 years ago

done!