search

sonata-project / GoogleAuthenticator

[Abandoned] Library to integrate Google Authenticator into a PHP project
https://github.com/sonata-project/GoogleAuthenticator
MIT License
436 stars 120 forks source link

Use different QR generation site as Google Chart API no longer supports QR codes #137

Closed netniV closed 5 years ago

netniV commented 5 years ago

Use different QR generation site as Google Chart API no longer supports QR codes

This is a fix for the #136 issue

I am targeting this branch, because Google depreciated their old API

Closes #136

Changelog

### Fixed
- Invalid/deprecated Google URL for QR code generation
OskarStark commented 5 years ago

Hey @netniV 👋

Thank you for your contribution, can you please change travis and fix the failing tests?

Thank you!

netniV commented 5 years ago

Sure, wondered what you meant at first then I realised you have tests that are using these and travis is moaning that they don't match (correctly) 👍

netniV commented 5 years ago

So I updated the tests, but yet Travis is still not happy for some reason, did I miss something?

netniV commented 5 years ago

Never mind, spotted it, I only changed one of the tests not all of them.

kunicmarko20 commented 5 years ago

@olenichphp @jgaranae @anomis66 can someone test this and confirm the fix

netniV commented 5 years ago

Thanks for the review @OskarStark. Should all be sorted now.