Closed paaaaaaaaaa closed 5 years ago
Hey there!
It looks like you did not fill the pull request template properly. Maybe you were confused, so let me walk you through this step by step.
I am targeting this branch, because {reason}.
Here, you are supposed to replace {reason}
with something like:
That one is really important to get right, because it will be used to craft a release changelog such as this one. The first thing you need to know about this is that if your pull request is pedantic, meaning it does not fix a bug for the user, or adds a new feature, it is not needed. This is typically the case for PRs that fix the build or add some documentation.
3 important things:
Thanks @paaaaaaaaaa
Hot fix
This pull request will prevent php type casting a float when a integer is required. Resulting in the following fatal error.
PHP Fatal error: Uncaught TypeError: str_repeat() expects parameter 2 to be integer, float given...
This may happen when a custom secret is generated that is not 10 characters long.
I am targeting this branch because it is the current default.
Changelog