search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Sidebar toggle buttion is not working with AdminLTE 2.4 #5066

Closed soullivaneuh closed 4 years ago

soullivaneuh commented 6 years ago

Subject

Because of a missing attribute. I'm working on it.

soullivaneuh commented 6 years ago

Well, we can't currently fix it because it's introduce a BC break.

In 2.3:

<a href="#" class="sidebar-toggle" data-toggle="offcanvas" role="button"></a>

In 2.4:

<a href="#" class="sidebar-toggle" data-toggle="push-menu" role="button"></a>

As we currently use 2.3, I can't change it. I leave the issue opened for the time we will upgrade.

A tiny hack is possible if you still want to upgrade AdminLTE yourself:

jQuery(document).ready(() => {
  $('a.sidebar-toggle[data-toggle="offcanvas"]').attr('data-toggle', 'push-menu');
});
jordisala1991 commented 6 years ago

Tagged as major enhancement, since we use 2.3 and it is not a bug.

soullivaneuh commented 6 years ago

@jordisala1991 The issue itself is not a major. I don't see why we can't allow upgrade for JS package.

The other issue that will be major is the migration to a yarn/npm package. :+1:

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.