search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Improve functionality by split Admin - concept for discussion #6079

Closed wbloszyk closed 3 years ago

wbloszyk commented 4 years ago

Feature Request

I very often use admin to generate CRUD for adminstrator. Write some configuration and all just work excelent. It is awsome!!! I have also project where CRUD is require in employee panel. There i must write it myself. While help with contribiute sonata-project I learn structures and got some IDEA.

At first what is Admin? - a comprehensive set of tools for the administrative panel

My IDEA

What we get?

It is only concept. I can expand if you are intrested.

We should end current work too.

VincentLanglet commented 4 years ago

My IDEA

  • split admin to atomic service by functionality
  • current AbstractAdmin should be support in 4.x and drop in 5.x

You can take a look at https://github.com/sonata-project/SonataAdminBundle/issues/3947

It is only concept. I can expand if you are intrested.

We should end current work too.

Yes, I would be already happy if we achieve to release Sonata 4.0 with a Symfony 5 and Twig 3 compatibility this year 😄

core23 commented 4 years ago

I really like the idea :+1: but when I look back to all big changes we could accomplish since the release of 3.0.0 (released around 2016) the chances to do this are getting lower and lower. We still have some bigger problems we need to solve first.

IMHO we should not accept any more bigger changes for the next major release and start finishing. After the release we should discuss what to do next.

VincentLanglet commented 4 years ago

Yes I agree, this should not be in the 4.0.

core23 commented 4 years ago

Can we agree to feature freeze the 4.x / master branch please.

cc @sonata-project/contributors

greg0ire commented 4 years ago

This is definitely not going to be in 4.0 . To make everyone happy, we should try not to wait too much before releasing 5.0. Maybe setting an arbitrary date in the future like exactly 1 year after 4.0 would help.

wbloszyk commented 4 years ago

Probably we can inject low level service to admin and use it like current Admin API. Drop it in 5.0. We can model IT befor release 4.0 and decide what to do.

VincentLanglet commented 4 years ago

Can we agree to feature freeze the 4.x / master branch please.

cc @sonata-project/contributors

I think there is still a lot of changes in the 4.x TODO-list:

I can't say how much time is needed for that so I have trouble to say "We won't add any features on 3.x during a lot of months". Or maybe I mis-understood what you mean @core23 ?

greg0ire commented 4 years ago

I don't think we should stop adding any features at any point. IMO we should have a list such as yours, have it be immutable and when every box is checked, we release. I'd remove the 2 Maybe from your list. If someone manages to do them before the other they can go in the release, but otherwise, let's not block this.

wbloszyk commented 4 years ago

Droping CoreBundle is almost done. I have sandbox with symfony4 and bootstrap4. We can improve this templates and add in sonata 3 to support bootstrap 3 and 4. Encore is alost rtm. Some change like optional encore should be add.

VincentLanglet commented 4 years ago

I have sandbox with symfony4 and bootstrap4. We can improve this templates and add in sonata 3 to support bootstrap 3 and 4.

Nice ! Does font-awesome 5 is coming with this changes too ?

wbloszyk commented 4 years ago

I dont remember. This is new feature, we can add it too or even support many version. Lets merge sandbox symfony4 and flex then we can add feature branches for some templates like bootstrap3, 4 ... Sandbox include all bundles, symfony4 allow use templates directory to override all bundles templetes in one directory. After accept branch we can just move it to bundle resources.

core23 commented 4 years ago

I can't say how much time is needed for that so I have trouble to say "We won't add any features on 3.x during a lot of months". Or maybe I mis-understood what you mean @core23 ?

I meant, that we should not introduce any new fancy features for the master branch. We should not introduce any more BC breaks for the major update. This will move the release in the farther future. We should refocus which feature we want for the next major and which we could finish soon

wbloszyk commented 4 years ago

I think this feature can be BC. We can add this feature to AbstractAdmin without change API and make BC-break in 5. In some version od admin 4.x we will have two way to use admin.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

VincentLanglet commented 3 years ago

I think we can close this as it's a duplicate of https://github.com/sonata-project/SonataAdminBundle/issues/3947 I'll recommend you to post your idea in the other issue instead @wbloszyk.