Closed VincentLanglet closed 3 years ago
@VincentLanglet When listed methods are removed, is there anything more to be done (for example is there need to add Symfony's ValidatorInterface
somewhere)? I tried to search to see where validate methods are called throughout the code, SetObjectFieldValueAction
uses ValidatorInterface
and the rest is in the list you provided.
@VincentLanglet When listed methods are removed, is there anything more to be done (for example is there need to add Symfony's
ValidatorInterface
somewhere)? I tried to search to see where validate methods are called throughout the code,SetObjectFieldValueAction
usesValidatorInterface
and the rest is in the list you provided.
We want to remove all the validation
features from the Admin, so there is nothing to add.
I look at SetObjectFieldValueAction
and we should keep it.
So it require to add in 3.x
/**
* NEXT_MAJOR: Remove this methods.
*
* @deprecated since sonata-admin/admin-bundle 3.x
*/
In the interface for all the validate-related methods, with an upgrade note and to remove all these methods in master.
And what about defineFormBuilder
method in AbstractAdmin
it calls attachInlineValidator
? I'll remove the line but not sure if any additional action on the method is needed.
Only the call $this->attachInlineValidator();
should be removed in defineFormBuilder
As explained in the AdminInterface, the
validate
method doesn't work well (we have bug issue) and is useless since Symfony have his own form validation.I create this issue because we only added one
NEXT_MAJOR
comment but there is no real removal-plan, we'll have at least to:We should also add a deprecation in 3.x.