Annotation mismatch with modifier

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator

https://docs.sonata-project.org/projects/SonataAdminBundle

MIT License

2.11k stars 1.26k forks source link

Annotation mismatch with modifier #6314

Closed kirya-dev closed 4 years ago

kirya-dev commented 4 years ago

SonataAdminBindle 3.74

if search next string in admin bundle @final since sonata-project/admin-bundle 3. (any past version) we can see that methods and classes does not have final modifiers.

For example https://github.com/sonata-project/SonataAdminBundle/blob/d0faf8a2123876f41ac225580044877dcffd3092/src/Admin/AbstractAdmin.php#L1494-L1498

VincentLanglet commented 4 years ago

Writing

final public function createQuery($context = 'list')

would be a BC-break.

We add @final to softly warn This will be final in next major.

kirya-dev commented 4 years ago

Okay. Can close :)